Merged
Conversation
Signed-off-by: Jorgen Kvalvaag <jorgen.kvalvaag@nordicsemi.no>
jorgenmk
force-pushed
the
bugfix-build
branch
3 times, most recently
from
6e554d0 to
1d97739
Compare
There was a problem hiding this comment.
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
.github/actions/build-step/action.yml:7
- The default value 'fookey' for memfault_project_key appears to be a placeholder and should be updated to a more meaningful or secure default.
default: "fookey"
.github/actions/build-step/action.yml:89
- The usage of '${{ env.VERSION }}' may be incorrect since the version output from the setup step is available as '${{ steps.setup.outputs.VERSION }}'. Consider updating this to ensure the correct version is used in the artifact filename.
sed '1d' ${{ inputs.path }}/build/partition_manager_report.txt > artifacts/pmr-${{ inputs.short_board }}-nrf91-default-${{ env.VERSION }}.txt
Update status of PR after target tests pass. Signed-off-by: Jorgen Kvalvaag <jorgen.kvalvaag@nordicsemi.no>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update PR status
Move build details into action